Only print debug messages when --debug is passed #385
Conversation
Summary of ChangesHello @ericcurtin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `cmd/cli/commands/run.go:679-680` </location>
<code_context>
}
- if _, err := ensureStandaloneRunnerAvailable(cmd.Context(), asPrinter(cmd)); err != nil {
+ debug, _ := cmd.Flags().GetBool("debug")
+ if _, err := ensureStandaloneRunnerAvailable(cmd.Context(), asPrinter(cmd), debug); err != nil {
return fmt.Errorf("unable to initialize standalone model runner: %w", err)
}
</code_context>
<issue_to_address>
**issue (bug_risk):** Error from GetBool("debug") is ignored; consider handling it explicitly.
Handling the error from flag parsing will help prevent silent failures and improve reliability.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a --debug flag to several commands to control verbose logging, replacing the previous environment variable-based check. The changes correctly propagate the debug flag through various functions. I've found two issues: one is a bug where the debug flag is not correctly passed during automatic runner installation, and the other is a minor code redundancy in the run command. Overall, this is a good improvement for controlling log verbosity.
ericcurtin
force-pushed
the
debug-logs
branch
2 times, most recently
from
c06d158 to
7d1deff
Compare
The ones that are too verbose for normal usage. Signed-off-by: Eric Curtin <[email protected]>
ericcurtin
force-pushed
the
debug-logs
branch
from
7d1deff to
3241dcc
Compare
The ones that are too verbose for normal usage.